[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/2] ppc4xx_sdram: Simplify sdram_ddr_size() to return
|
From: |
Markus Armbruster |
|
Subject: |
[PATCH 3/2] ppc4xx_sdram: Simplify sdram_ddr_size() to return |
|
Date: |
Wed, 23 Nov 2022 08:06:50 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Suggested-by: BALATON Zoltan <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
---
hw/ppc/ppc4xx_sdram.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw/ppc/ppc4xx_sdram.c b/hw/ppc/ppc4xx_sdram.c
index 54bf9a2b44..a24c80b1d2 100644
--- a/hw/ppc/ppc4xx_sdram.c
+++ b/hw/ppc/ppc4xx_sdram.c
@@ -192,17 +192,13 @@ static inline hwaddr sdram_ddr_base(uint32_t bcr)
static hwaddr sdram_ddr_size(uint32_t bcr)
{
- hwaddr size;
- int sh;
+ int sh = (bcr >> 17) & 0x7;
- sh = (bcr >> 17) & 0x7;
if (sh == 7) {
- size = -1;
- } else {
- size = (4 * MiB) << sh;
+ return -1;
}
- return size;
+ return (4 * MiB) << sh;
}
static uint32_t sdram_ddr_dcr_read(void *opaque, int dcrn)
--
2.37.3
- Re: [PATCH v2 2/2] block/vmdk: Simplify vmdk_co_create() to return directly, (continued)
- [PATCH 3/2] ppc4xx_sdram: Simplify sdram_ddr_size() to return,
Markus Armbruster <=