[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/11] migration: Make ram_save_target_page() a pointer
From: |
Juan Quintela |
Subject: |
[PATCH 05/11] migration: Make ram_save_target_page() a pointer |
Date: |
Mon, 28 Nov 2022 11:04:16 +0100 |
We are going to create a new function for multifd latest in the series.
Signed-off-by: Juan Quintela <[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
---
migration/ram.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 334309f1c6..48cbba3173 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -450,6 +450,13 @@ void dirty_sync_missed_zero_copy(void)
ram_counters.dirty_sync_missed_zero_copy++;
}
+struct MigrationOps {
+ int (*ram_save_target_page)(RAMState *rs, PageSearchStatus *pss);
+};
+typedef struct MigrationOps MigrationOps;
+
+MigrationOps *migration_ops;
+
CompressionStats compression_counters;
struct CompressParam {
@@ -2265,14 +2272,14 @@ static bool save_compress_page(RAMState *rs,
PageSearchStatus *pss,
}
/**
- * ram_save_target_page: save one target page
+ * ram_save_target_page_legacy: save one target page
*
* Returns the number of pages written
*
* @rs: current RAM state
* @pss: data about the page we want to send
*/
-static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss)
+static int ram_save_target_page_legacy(RAMState *rs, PageSearchStatus *pss)
{
RAMBlock *block = pss->block;
ram_addr_t offset = ((ram_addr_t)pss->page) << TARGET_PAGE_BITS;
@@ -2381,7 +2388,7 @@ static int ram_save_host_page_urgent(PageSearchStatus
*pss)
if (page_dirty) {
/* Be strict to return code; it must be 1, or what else? */
- if (ram_save_target_page(rs, pss) != 1) {
+ if (migration_ops->ram_save_target_page(rs, pss) != 1) {
error_report_once("%s: ram_save_target_page failed", __func__);
ret = -1;
goto out;
@@ -2450,7 +2457,7 @@ static int ram_save_host_page(RAMState *rs,
PageSearchStatus *pss)
if (preempt_active) {
qemu_mutex_unlock(&rs->bitmap_mutex);
}
- tmppages = ram_save_target_page(rs, pss);
+ tmppages = migration_ops->ram_save_target_page(rs, pss);
if (tmppages >= 0) {
pages += tmppages;
/*
@@ -2645,6 +2652,8 @@ static void ram_save_cleanup(void *opaque)
xbzrle_cleanup();
compress_threads_save_cleanup();
ram_state_cleanup(rsp);
+ g_free(migration_ops);
+ migration_ops = NULL;
}
static void ram_state_reset(RAMState *rs)
@@ -3198,6 +3207,8 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
ram_control_before_iterate(f, RAM_CONTROL_SETUP);
ram_control_after_iterate(f, RAM_CONTROL_SETUP);
+ migration_ops = g_malloc0(sizeof(MigrationOps));
+ migration_ops->ram_save_target_page = ram_save_target_page_legacy;
ret = multifd_send_sync_main(f);
if (ret < 0) {
return ret;
--
2.38.1
- [PATCH 00/11] Multifd zero page support, Juan Quintela, 2022/11/28
- [PATCH 01/11] migration: Update atomic stats out of the mutex, Juan Quintela, 2022/11/28
- [PATCH 03/11] multifd: We already account for this packet on the multifd thread, Juan Quintela, 2022/11/28
- [PATCH 02/11] migration: Make multifd_bytes atomic, Juan Quintela, 2022/11/28
- [PATCH 05/11] migration: Make ram_save_target_page() a pointer,
Juan Quintela <=
- [PATCH 04/11] multifd: Count the number of bytes sent correctly, Juan Quintela, 2022/11/28
- [PATCH 07/11] multifd: Prepare to send a packet without the mutex held, Juan Quintela, 2022/11/28
- [PATCH 06/11] multifd: Make flags field thread local, Juan Quintela, 2022/11/28
- [PATCH 08/11] multifd: Add capability to enable/disable zero_page, Juan Quintela, 2022/11/28
- [PATCH 09/11] multifd: Support for zero pages transmission, Juan Quintela, 2022/11/28
- [PATCH 10/11] multifd: Zero pages transmission, Juan Quintela, 2022/11/28
- [PATCH 11/11] So we use multifd to transmit zero pages., Juan Quintela, 2022/11/28